New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon Version Check Database Bug in Multiplayer Lobby #4055
Comments
Likely reason is that the variables
Ideally there should not be two variables that need to be in sync. All the info should be in one place. |
I've seen this a couple of times recently, after building from source. I've just tried pressing "Create Game", and found that the only eras that are installed are the default four, although I definitely have Ageless installed in my add-ons folder. Purging the cache did not fix it, nor did exiting and restarting. I then tried creating a local multiplayer game instead of connecting to the server. That gave the expected long list of eras, in the Create Game screen, After that, I joined the multiplayer server and my installed eras showed up. So I've a suspicion that the database used when connected to the server is only being created when creating a local game. |
Is it with filesystem manipulation (e.g. removing add-ons), or without? I easily get it if I mangle with addons, but the issue always goes away if I clear the cache in Preferences and then press F5 in the main screen |
can confirm this still happening. First time i found this message while on Wesnoth 1.16.5. As some mentioned before, clearing cache didnt help |
For the record there is no database involved here. Just code checking the game info and getting confused. |
It'd be still nice to have a reliable way to reproduce it, even with filesystem manipulation. |
If nothing else, an error message that's actually accurate would be nice. |
Even if it would be that simple, we are already in string freeze currently |
Writing a more sensible error message to the logs for now would still be an improvement. |
So this randomyl happend to me on the 1.16 multiplayer server, so i took a look at what the client actually receives:
As you can see, in the |
After downloading said addon, i noticed that the modifications inside indeed have |
The problem is that here we write wesnoth/src/mp_game_settings.cpp Line 167 in 9877b8e
But what we actually read is required wesnoth/src/mp_game_settings.cpp Line 144 in 9877b8e
|
@gfgtdf does this fix need to be forwardported? |
No 1.17 already has another fix |
(the fix for 1.16 is different for compatibility reasons) |
So this can be closed? |
I'd say so, yes |
Actually while this fixes probably the most common cause, it can still happen in case of bad umc code, for example when one player modifies their addon to add a tag to it that the other players doesn't have. I do think that we should still at least give a better error message in those cases. |
Hey there, just reporting this bug as I was asked by the developers. I couldn't join the game at the bottom of the list "segfaulted's game." Then this error came up.
I am running version 1.14.5
Hope this helps, thanks!
The text was updated successfully, but these errors were encountered: