Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Denoise (profiled) : Noise profiles not loading for Nikon DSLR cameras (JPG pictures) #6644

Closed
GLLM opened this issue Oct 26, 2020 · 8 comments · Fixed by #13851
Closed

Denoise (profiled) : Noise profiles not loading for Nikon DSLR cameras (JPG pictures) #6644

GLLM opened this issue Oct 26, 2020 · 8 comments · Fixed by #13851
Labels
bug: upstream he bug needs a fix outside of the scope of darktable, in an external lib or in a driver no-issue-activity

Comments

@GLLM
Copy link

GLLM commented Oct 26, 2020

Hello all,

I'm running Dt 3.2.1 on Linux Kubuntu 20.10

I'm using Denoise (Profiled) module and it works perfectly with my Fujifilm X-T3 camera.

But, when I'm retouching photos (JPG) taken with (not owned anymore) Nikon DSLRs, the profile is neither seen nor loaded/loadable in this module.

image

I've looked into noiseprofiles.json file and wonder if this could be caused by the fact that :

  • Nikon maker is spelled "Nikon", whereas any of my pictures taken with Nikon DSLR have their maker set (never manually changed) as "NIKON CORPORATION"
  • Nikon DSLR are named as Dxxxx where any of my pictures are showing "NIKON Dxxxx"

Camera & Maker as visible on one of my pic :
image

Camera list of my collection
image

I've therefore edited /usr/share/darktable/noiseprofiles.json and I've tested changing "Nikon" maker to "NIKON CORPORATION" and "D600" to "NIKON D600" and ....
hurrah, the camera is recognized and therefore the noise profile is visible and can be loaded.

image
image

Questions

  • How do you see both Nikon maker shown and the camera named in the image information module (left pane) ?
  • Anyone is not able to use noise profiles with JPG pictures taken with Nikon DSLRs ?
  • Can you fix this

Usual addendum :

  • running Kubuntu 20.10, but issue was the same on K20.04, K19.10, K19.04 ...
  • I have wasy enough RAM (32GB) and a healthy CPU i7700K + run with OpenCL on GFX 1070.

Thanks
GLLM
@GLLM GLLM mentioned this issue Oct 26, 2020
Closed
@GLLM
Copy link
Author

GLLM commented Nov 17, 2020

Up !

@github-actions
Copy link

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@johnny-bit johnny-bit added bug: upstream he bug needs a fix outside of the scope of darktable, in an external lib or in a driver and removed no-issue-activity labels Dec 20, 2020
@johnny-bit
Copy link
Member

I think this might be unfixable by darktable but rather it might be a combination of couple issues:

  • I wouldn't do denoising on JPEGs as camera usually denoises those + jpeg compression also does some denoising
  • the exif data seems to be different enough on RAWs and JPEGs for exiv2 to misrepresent/mistranslate those files
  • maybe there was some change along the way with jpegs because I checked some Nikon jpegs from my friends and haven't got a problem with them... so I essentially cannot replicate.

How about this - try to remove and then re-import images, making sure you have recent enough verson on exiv2. If that helps - please close the issue :)

@github-actions
Copy link

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@GLLM
Copy link
Author

GLLM commented Feb 2, 2021

Hi @johnny-bit !
Thanks for your reply !

It happens that I had to rename (externally) 10k+ pictures taken with my previous Nikon DSLR ... hence I had to re-import them in dt. And unfortunately, this did not solve anything !

About JPEG : the denoise (profile), when used wisely & lightly, can help greatly ... even on JPEGs :-)

I just reinstalled exiv2 0.27.3 ... to no avail.

Indeed, on a RAW (NEF) file, it works ok.
In fact, the Maker & Model (and evn lens) info are different between the NEF and the JPEG files ! Not sure why, as I did not change any of them :

JPEG
image

NEF (RAW)
image

So, I'm indeed not sure how to deal with this.

Oh, and I don't know why, but Lens correction module does not bother : it works with both

Thanks
GLLM

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@jonplarson
Copy link

I just encountered a similar Issue with my Nikon Z 6ii Where the profiles didn't show up due to the naming differences.

@kmilos
Copy link
Contributor

kmilos commented Feb 28, 2023

See also discussion at #13712

Indeed something going on...

@kmilos kmilos mentioned this issue Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: upstream he bug needs a fix outside of the scope of darktable, in an external lib or in a driver no-issue-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

imageio: lookup camera make/model in any mode available kmilos/darktable
4 participants
@GLLM @kmilos @jonplarson @johnny-bit